feat: Add native thread configs #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
force-pushed
the
add_thread_configs
branch
2 times, most recently
from
5d4f4e8 to
b00c8f2
Compare
viirya
force-pushed
the
add_thread_configs
branch
from
b00c8f2 to
689b53e
Compare
andygrove
reviewed
Aug 14, 2024
Comment on lines
+149
to
+150
| .worker_threads(worker_threads) | ||
| .max_blocking_threads(blocking_threads) |
There was a problem hiding this comment.
For reference, we were previously using these defaults:
// Read from environment variable first in multi-threaded mode.
// Default to lazy auto-detection (one thread per CPU core)
worker_threads: None,
max_blocking_threads: 512,
There was a problem hiding this comment.
I ran benchmarks and did not see any regression in performance. It was actually 2% faster but that could be noise.
andygrove
approved these changes
Aug 15, 2024
|
Thanks @andygrove |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #829.
Rationale for this change
What changes are included in this PR?
How are these changes tested?