chore: Add documentation on running benchmarks with Microk8s #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
Aug 19, 2024
comphead
reviewed
Aug 19, 2024
comphead
reviewed
Aug 19, 2024
| --jars local://$COMET_JAR \ | ||
| --conf spark.executor.extraClassPath=$COMET_JAR \ | ||
| --conf spark.driver.extraClassPath=$COMET_JAR \ | ||
| --conf spark.plugins=org.apache.spark.CometPlugin \ |
comphead
reviewed
Aug 19, 2024
| --name comet-tpcbench \ | ||
| --driver-memory 8G \ | ||
| --conf spark.driver.memory=8G \ | ||
| --conf spark.executor.instances=1 \ |
There was a problem hiding this comment.
for benches its probably good to run it in scale? to put instances > 1
There was a problem hiding this comment.
This is really meant as an example. I would expect users to customize the script for their local environment.
comphead
approved these changes
Aug 19, 2024
Co-authored-by: Oleks V <comphead@users.noreply.github.com>
kazuyukitanimura
approved these changes
Aug 23, 2024
|
@andygrove are you planning to merge it, I'd also like to add the Helm chart section to run in the Kubernetes cluster |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #602
Rationale for this change
What changes are included in this PR?
How are these changes tested?