build: Upgrade spotless version to 2.43.0 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, it's not compatible with Java 8. |
viirya
force-pushed
the
upgrade_spotless
branch
from
fb35926
to
69eb711
Compare
sunchao
reviewed
Feb 22, 2024
| @@ -38,9 +38,17 @@ runs: | |||
| shell: bash | |||
| run: | | |||
| echo "JAVA_VERSION=${JAVA_VERSION}" | |||
| ./mvnw -B compile test-compile scalafix:scalafix -Psemanticdb -Djava.version=${JAVA_VERSION} | |||
| if [ $JAVA_VERSION == "1.8" ]; then | |||
| ./mvnw -B compile test-compile scalafix:scalafix -Psemanticdb -Djava.version=${JAVA_VERSION} -Dspotless.version=2.29.0 | |||
There was a problem hiding this comment.
is it OK to use 2.29.0 for Java 8?
There was a problem hiding this comment.
This line uses 2.29.0 for Java 8, isn't?
There was a problem hiding this comment.
I mean whether we'll run into the issue mentioned in the PR description if we use 2.29 for Java 8
There was a problem hiding this comment.
I think it is no.
This issue is particular for Java 21: diffplug/spotless#1791
sunchao
approved these changes
Feb 22, 2024
|
Merged. Thanks. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Current spotless
2.29.0doesn't work with Apache Maven 3.9.6 + Java version: 21.0.2.What changes are included in this PR?
How are these changes tested?