feat: Simplify configs for enabling/disabling operators #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
approved these changes
Aug 20, 2024
comphead
reviewed
Aug 20, 2024
| @@ -1240,7 +1235,7 @@ class CometExecSuite extends CometTestBase { | |||
| .saveAsTable("bucketed_table2") | |||
|
|
|||
| withSQLConf( | |||
| "spark.comet.exec.sortMergeJoin.disabled" -> "true", | |||
| CometConf.COMET_EXEC_SORT_MERGE_JOIN_ENABLED.key -> "false", | |||
There was a problem hiding this comment.
true -> false change, is it related?
There was a problem hiding this comment.
This is to disable sort merge join. Previously it is a disabled config. Now it is enabled config.
|
Thanks @andygrove @parthchandra @comphead |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
* stop unpacking dictionaries for hash join input * simply configs * Revert * simplify configs * code cleanup and revert changes to FilterExec * Revert * revert * cargo update * add comment * update plans * update tests * enable stddev * revert plan changes * update configs * revert unrelated changes (cherry picked from commit fbf389c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Simplify configs so that there is one "enabled" config per oeprator, defaulting to true. We can disable operators by setting to false.
What changes are included in this PR?
How are these changes tested?