perf: Add criterion benchmark for aggregate expressions #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
andygrove
changed the title
This was referenced Sep 18, 2024
huaxingao
reviewed
Sep 18, 2024
native/core/Cargo.toml
Outdated
|
|
||
| [[bench]] | ||
| name = "aggregate" | ||
| harness = false |
There was a problem hiding this comment.
nit: shall we add an empty line to the end of the file?
kazuyukitanimura
approved these changes
Sep 18, 2024
| }); | ||
|
|
||
| group.bench_function("sum_decimal_comet", |b| { | ||
| let comet_sum_decimal = Arc::new(AggregateUDF::new_from_impl(SumDecimal::new( |
There was a problem hiding this comment.
do we need to use blackbox to avoid the optimization?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #948 +/- ##
============================================
- Coverage 34.15% 34.02% -0.13%
+ Complexity 881 876 -5
============================================
Files 112 112
Lines 43276 43276
Branches 9572 9572
============================================
- Hits 14779 14725 -54
- Misses 25478 25518 +40
- Partials 3019 3033 +14 ☔ View full report in Codecov by Sentry. |
viirya
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Add Criterion benchmark to compare DataFusion and Comet aggregate expressions.
What changes are included in this PR?
New benchmark
How are these changes tested?
Manually