feat: Support GetArrayStructFields expression
#993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimahriman
changed the title
GetArrayStructFields expression
Kimahriman
changed the title
GetArrayStructFields expressionGetArrayStructFields expression
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
=============================================
+ Coverage 34.03% 54.84% +20.81%
+ Complexity 875 858 -17
=============================================
Files 112 109 -3
Lines 43289 10841 -32448
Branches 9572 2101 -7471
=============================================
- Hits 14734 5946 -8788
+ Misses 25521 3821 -21700
+ Partials 3034 1074 -1960
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
andygrove
reviewed
Oct 2, 2024
| @@ -2542,6 +2542,25 @@ object QueryPlanSerde extends Logging with ShimQueryPlanSerde with CometExprShim | |||
| None | |||
| } | |||
|
|
|||
| case GetArrayStructFields(child, _, ordinal, _, _) => | |||
There was a problem hiding this comment.
To help other reviewers, here is Spark's definition of GetArrayStructFields:
case class GetArrayStructFields(
child: Expression,
field: StructField,
ordinal: Int,
numFields: Int,
containsNull: Boolean)There was a problem hiding this comment.
Yeah those other three fields aren't relevant for actual execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #992
Rationale for this change
Support the last complex type extractor for arrays and structs.
What changes are included in this PR?
Adds support for the
GetArrayStructFieldsexpression in Spark which extracts a nested struct field of an array of structs as an array of the inner field type.How are these changes tested?
New expression UT.