Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fallback to Spark if scan has meta columns #997

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

viirya
Copy link
Member

@viirya viirya commented Oct 6, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

Currently Comet scan cannot work with Iceberg reader internally if there is meta columns. We should fallback to Spark for the case before we can support meta column.

What changes are included in this PR?

How are these changes tested?

Manually test with Iceberg tests.

@viirya viirya requested review from huaxingao and andygrove October 6, 2024 07:19
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 34.31%. Comparing base (c3023c5) to head (1a07658).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
...org/apache/comet/CometSparkSessionExtensions.scala 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #997      +/-   ##
============================================
+ Coverage     34.03%   34.31%   +0.27%     
- Complexity      875      889      +14     
============================================
  Files           112      112              
  Lines         43289    43438     +149     
  Branches       9572     9617      +45     
============================================
+ Hits          14734    14904     +170     
+ Misses        25521    25509      -12     
+ Partials       3034     3025       -9     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andygrove andygrove merged commit 0028f1e into apache:main Oct 7, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants