Support DECLARE syntax for snowflake and bigquery
#1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current support for `DECLARE` statements are primarily aimed at postgres-compatible syntax which differs significantly for snowflake and bigquery. This adds support for both dialects. Generic still parses the postgres-compatible syntax since that should have the most coverage in terms of support.
Pull Request Test Coverage Report for Build 7756478317
💛 - Coveralls |
6 tasks
8 tasks
alamb
changed the title
DECLARE support for snowflake and bigqueryDECLARE syntax for snowflake and bigquery
9 tasks
|
@alamb Not a problem at all, yeah I understood your bandwidth for the project so no hurry on my end! Thanks a lot for the review! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current support for
DECLAREstatements are primarily aimed at postgres-compatible syntax which differs significantly for snowflake and bigquery.This adds support for both dialects.
Generic is left to still parse the postgres-compatible syntax since that should have the most coverage in terms of support.