Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SupportSELECT AS VALUE and SELECT AS STRUCT for BigQuery #1135

Merged
merged 1 commit into from
Feb 29, 2024
Merged

SupportSELECT AS VALUE and SELECT AS STRUCT for BigQuery #1135

merged 1 commit into from
Feb 29, 2024

Conversation

lustefaniak
Copy link
Contributor

@lustefaniak lustefaniak commented Feb 14, 2024 •
edited
Loading

Closes #1126

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7902491902

Details

  • -3 of 53 (94.34%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 87.697%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_bigquery.rs 10 11 90.91%
src/parser/mod.rs 7 9 77.78%
Totals Coverage Status
Change from base Build 7878309063: 0.01%
Covered Lines: 19688
Relevant Lines: 22450
💛 - Coveralls

@alamb alamb mentioned this pull request Feb 26, 2024
Closed
9 tasks
@alamb alamb changed the title bigquery: Add support for parsing SELECT AS VALUE and SELECT AS STRUCT SupportSELECT AS VALUE and SELECT AS STRUCT for BigQuery Feb 29, 2024
alamb
alamb approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lustefaniak -- looks good to me

@alamb alamb merged commit 1cf6585 into apache:main Feb 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BigQuery's dialect SELECT AS STRUCT and SELECT AS VALUE ends up with Parse Error
3 participants
@lustefaniak @coveralls @alamb