Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CREATE FUNCTION round trip for Hive dialect #1693

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Fix CREATE FUNCTION round trip for Hive dialect #1693

merged 1 commit into from
Jan 30, 2025

Conversation

iffyio
Copy link
Contributor

@iffyio iffyio commented Jan 30, 2025

Fixes the test failure in #1690

@iffyio
Copy link
Contributor Author

iffyio commented Jan 30, 2025

My bad, I somehow managed to miss that the test was failing before merging

@iffyio iffyio requested a review from alamb January 30, 2025 07:45
@gstvg gstvg mentioned this pull request Jan 30, 2025
Merged
alamb
alamb approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iffyio -- sorry for the delay in reviewing

@alamb alamb merged commit 9c384a9 into apache:main Jan 30, 2025
9 checks passed
@iffyio iffyio deleted the create-function-args-test-failure branch January 31, 2025 05:55
@iffyio
Copy link
Contributor Author

iffyio commented Jan 31, 2025

Thanks @alamb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iffyio @alamb