Parse SET GLOBAL variable modifier for MySQL #1696
Open
+87
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also stops rewriting `SESSION` away. Closes apache#1694
iffyio
reviewed
Jan 31, 2025
| Self::Local => write!(f, " LOCAL"), | ||
| Self::Session => write!(f, " SESSION"), | ||
| Self::Global => write!(f, " GLOBAL"), | ||
| Self::None => write!(f, ""), |
There was a problem hiding this comment.
does it work the same to define scope as an optional field (scope: Option<SetVariableScope>)? in order to represent None by convention?
| @@ -10533,8 +10533,17 @@ impl<'a> Parser<'a> { | |||
| } | |||
|
|
|||
| pub fn parse_set(&mut self) -> Result<Statement, ParserError> { | |||
| let modifier = | |||
| self.parse_one_of_keywords(&[Keyword::SESSION, Keyword::LOCAL, Keyword::HIVEVAR]); | |||
| let modifier_keywords = if self.dialect.supports_global_variable_modifier() { | |||
There was a problem hiding this comment.
I'm thinking having the lone global keyword as a dialect flag might not scale API wise, to make it dialect specific maybe it might make sense to have delegate to the dialect? like with parse_column_option as an example except with a default implementation that others like hive and mysql can override.
e.g.
let scope = self.dialect.parse_set_variable_scope(self)?;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also stops rewriting
SESSIONaway.Closes #1694