Fix character_length

apache · Aug 8, 2024 · f42aa84 · f42aa84
1 parent ead4a7c
commit f42aa84
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/datafusion/functions/src/unicode/character_length.rs b/datafusion/functions/src/unicode/character_length.rs
@@ -44,7 +44,7 @@ impl CharacterLengthFunc {
         Self {
             signature: Signature::uniform(
                 1,
-                vec![Utf8, LargeUtf8],
+                vec![Utf8, LargeUtf8, Utf8View],
                 Volatility::Immutable,
             ),
             aliases: vec![String::from("length"), String::from("char_length")],

diff --git a/datafusion/sqllogictest/test_files/string_view.slt b/datafusion/sqllogictest/test_files/string_view.slt
@@ -536,7 +536,7 @@ EXPLAIN SELECT
 FROM test;
 ----
 logical_plan
-01)Projection: character_length(CAST(test.column1_utf8view AS Utf8)) AS l
+01)Projection: character_length(test.column1_utf8view) AS l
 02)--TableScan: test projection=[column1_utf8view]
 
 ## Ensure no casts for CONCAT
@@ -934,5 +934,3 @@ select column2|| ' ' ||column3 from temp;
 ----
 rust fast
 datafusion cool
-
-