Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust_toml_fmt.sh is broken in multiple ways #9308

Closed
Omega359 opened this issue Feb 21, 2024 · 1 comment · Fixed by #9309
Closed

rust_toml_fmt.sh is broken in multiple ways #9308

Omega359 opened this issue Feb 21, 2024 · 1 comment · Fixed by #9309
Assignees
@Omega359
Labels
bug Something isn't working

Comments

@Omega359
Copy link
Contributor

Describe the bug

Introduced in #9263 there is two bugs with this file

  1. The bash syntax is incorrect.
  2. The format command is not run with --check. scripts run in ci should only ever check syntax, not fix it. That is the responsibility of the developer.

To Reproduce

Attempt to run /dev/rust-lint.sh which calls this script among others.

Expected behavior

The toml files are checked for syntax issues correctly but are not automatically fixed.

Additional context

No response
@Omega359 Omega359 added the bug Something isn't working label Feb 21, 2024
@Omega359
Copy link
Contributor Author

take

@Omega359 Omega359 mentioned this issue Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Omega359 Omega359

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix toml format script Omega359/arrow-datafusion
1 participant
@Omega359