-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use taplo to format Cargo.toml manifests #9263
Conversation
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't lie, it bugs me a little that name
is no longer the first key in this new format 😅
I guess it is better to have some defined order for keys, but can this be configured?
Unless others are fine with the default alphabetical 👍
This reverts commit 1819daa.
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Thanks for reviewing this @Jefffrey I added a rule to skip reordering |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🚀
This broke /dev/rust-lint.sh because /ci/scripts/rust_toml_fmt.sh isn't valid bash: set -ex |
Ahhh my bad 😵💫 Are you willing to submit a fix? |
Which issue does this PR close?
Closes #9262.
Rationale for this change
See #9262 for details.
What changes are included in this PR?
Changes:
Cargo.toml
filesTo install
taplo
, runcargo install taplo-cli
. Or by other ways in document.To format toml files, use
taplo format
. It would read config filetaplo.toml
from this PR.Are these changes tested?
no need
Are there any user-facing changes?
For developers, yes.