-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update contributor guide (format toml/inte test) #9301
Conversation
|
||
> Refer to the [Installation section][doc] on other ways to install it. | ||
> | ||
> doc: https://taplo.tamasfe.dev/cli/installation/binary.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching it! I missed that []
24bd2bb
to
9651e6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
For Rust developers, you can install it via: | ||
|
||
```sh | ||
$ cargo install taplo-cli --locked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ cargo install taplo-cli --locked | |
cargo install taplo-cli --locked |
Makes sense to show prompt but can be annoying when copying from that code block (via the copy button)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Thanks for this! |
9651e6c
to
45eb91b
Compare
Which issue does this PR close?
no
Rationale for this change
What changes are included in this PR?
Update the docs on integration test,
dataframe
is no longer a test target:Add docs on how to format
.toml
files, ref: chore: use taplo to format Cargo.toml manifests #9263 Proposal: replace toml formatter withtaplo
#9262Are these changes tested?
Are there any user-facing changes?
no