Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype implementing DataFusion functions / operators using arrow-udf liibrary #11488

Closed
wants to merge 5 commits into from

Conversation

xinlifoobar
Copy link
Contributor

@xinlifoobar xinlifoobar commented Jul 16, 2024

Which issue does this PR close?

Closes #11413

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added the physical-expr Physical Expressions label Jul 16, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very cool @xinlifoobar -- thank you

use datafusion_expr::ColumnarValue;
// use arrow_string::predicate::Predicate;

#[function("eq(boolean, boolean) -> boolean")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is pretty neat

format!("{}{}", lhs, rhs)
}

pub fn apply_udf(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the code that adapts ColumnarValue to being able to call the arrow-udf based functions via a record batch, right?

@alamb
Copy link
Contributor

alamb commented Jul 17, 2024

I will leave comments on #11413

@Xuanwo
Copy link
Member

Xuanwo commented Sep 6, 2024

Hello, everyone. Exciting news: arrow-udf now belongs to a new organization called arrow-udf. Please let me know if there is anything preventing us from moving forward. I'm happy to help address it.

cc @xinlifoobar and @alamb

Copy link

github-actions bot commented Nov 6, 2024

Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale PR has not had any activity for some time label Nov 6, 2024
@github-actions github-actions bot closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
physical-expr Physical Expressions Stale PR has not had any activity for some time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prototype implementing DataFusion functions / operators using arrow-udf liibrary
3 participants