fix: dont try to coerce list for regex match #11646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshauck
changed the title
tshauck
commented
Jul 25, 2024
| @@ -325,6 +325,11 @@ SELECT 'foo\nbar\nbaz' ~ 'bar'; | |||
| ---- | |||
| true | |||
|
|
|||
| statement error | |||
| Error during planning: Cannot infer common argument type for regex operation List(Field { name: "item", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata | |||
There was a problem hiding this comment.
A bit verbose, but tries to prove the error happens during planning.
|
I guess we don't need list coercion for |
+1, I'll wait a day or so to hear if it's there for a reason for it, otherwise I'll pull it out too. |
|
Thanks again @tshauck and @jayzhan211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11622
Rationale for this change
Regex match's args will try to be coerced from Lists, but that shouldn't be possible.
List coercion was added in #10445, but it's not clear to me why.
What changes are included in this PR?
Remove list coercion, add tests
Are these changes tested?
yes
Are there any user-facing changes?
No