Do not push down Sorts if it violates the sort requirements #11678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Jul 26, 2024
| @@ -176,6 +176,7 @@ fn pushdown_requirement_to_children( | |||
| || plan.as_any().is::<ProjectionExec>() | |||
| || is_limit(plan) | |||
| || plan.as_any().is::<HashJoinExec>() | |||
| || pushdown_would_violate_requirements(parent_required, plan.as_ref()) | |||
There was a problem hiding this comment.
In general it would be great to avoid these explicit checks for types over time in favor of functions on the ExecutionPlan nodes
alamb
force-pushed
the
alamb/sort_pushdown_not
branch
from
37b3b87
to
c0d08d2
Compare
alamb
commented
Jul 31, 2024
| let plan = sort_exec(sort_exprs_b, plan); | ||
|
|
||
| let expected_input = [ | ||
| "SortExec: expr=[b@1 ASC], preserve_partitioning=[false]", |
There was a problem hiding this comment.
This test fails on main -- specifically the SortExec is pushed below the RequiredInputOrderingExec so its input is sorted on b which violates its input requirements that it is sorted on a
mustafasrepo
approved these changes
Aug 1, 2024
|
Thank you for the review @mustafasrepo |
wiedld
pushed a commit
to wiedld/arrow-datafusion
that referenced
this pull request
Aug 8, 2024
…1678) * Do not push down Sorts if it violates the sort requirements * Test for pushing through orders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11675
Closes #11493
Rationale for this change
See #11675 -- the PushDown sort optimizer was incorrectly pushing down sorts in certain cases
This change fixes a problem we were seeing in our tests downstream in influxdb iox
What changes are included in this PR?
Are these changes tested?
Yes, new unit tests are added
Are there any user-facing changes?
Bug fix