Minor: Improve comments in row_hash.rs for skipping aggregation #11820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 5, 2024
andygrove
reviewed
Aug 7, 2024
Co-authored-by: Andy Grove <agrove@apache.org>
korowa
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
LGTM (just left a couple of suggestions).
Thank you @alamb @andygrove @2010YOUY01
Co-authored-by: Eduard Karacharov <eduard.karacharov@gmail.com>
alamb
changed the title
|
Thanks all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Follow on to #11627
Rationale for this change
@2010YOUY01 had some good suggestions on #11627 such as https://github.com/apache/datafusion/pull/11627/files#r1695417159 which I wanted to capture as part of filing the follow up work
What changes are included in this PR?
Update some comments
Are these changes tested?
Are there any user-facing changes?
Comment changes only, no functional changes