Fix build with --no-default-features
#1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Nov 1, 2021
| @@ -64,6 +64,12 @@ jobs: | |||
| env: | |||
| CARGO_HOME: "/github/home/.cargo" | |||
| CARGO_TARGET_DIR: "/github/home/target" | |||
| - name: Check DataFusion Build without default features | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
You can see it fail with the same symptoms reported on the bug: https://github.com/apache/arrow-datafusion/runs/4072959374?check_suite_focus=true#step:8:99
houqp
approved these changes
Nov 2, 2021
andygrove
pushed a commit
to andygrove/datafusion
that referenced
this pull request
Jan 31, 2025
…ing (apache#1219) * extract math_funcs expressions to folders based on spark grouping * fix merge conflicts and move chr to `string_funcs`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1217
Rationale for this change
#1141 added an explicit dependence on
lazy_staticbutlazy_staticis feature flagged underregex_expressionsat the moment (which is strange as it is already a transitive dependency -- see the output ofcargo tree -i lazy_static --no-default-featuresWhat changes are included in this PR?
lazy_staticincludeAre there any user-facing changes?
Build is fixed