-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Aggregation fuzzer framework #12667
Merged
Merged
Changes from 29 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
6514cd2
impl primitive arrays generator.
Rachelint 1a11133
sort out the test record batch generating codes.
Rachelint e0ea349
draft for `DataSetsGenerator`.
Rachelint c952bdf
tmp
Rachelint 214d67f
improve the data generator, and start to impl the session context gen…
Rachelint 04b4246
impl context generator.
Rachelint 6b2af7f
tmp
Rachelint 77d2268
define the `AggregationFuzzer`.
Rachelint 4bef192
add ut for data generator.
Rachelint e7fbf47
improve comments for `SessionContextGenerator`.
Rachelint 984f6aa
define `GeneratedSessionContextBuilder` to reduce repeated codes.
Rachelint 12e3f37
extract the check equality logic for reusing.
Rachelint ca4a40c
add ut for `SessionContextGenerator`.
Rachelint a4639de
tmp
Rachelint 0cfd035
finish the main logic of `AggregationFuzzer`.
Rachelint 8271079
try to rewrite some test using the fuzzer.
Rachelint d6e358e
fix header.
Rachelint 2279ab7
expose table name through `AggregationFuzzerBuilder`.
Rachelint 7deced4
throw err to aggr fuzzer, and expect them then.
Rachelint c5d80ce
switch to Arc<str> to slightly improve performance.
Rachelint b50ea49
throw more errors to fuzzer.
Rachelint 7a9118f
print task informantion before panic.
Rachelint ea6ad89
improve comments.
Rachelint 3d9bc15
support printing generated session context params in error reporting.
Rachelint bf7fc82
add todo.
Rachelint 2e35985
add some new fuzz case based on `AggregationFuzzer`.
Rachelint 0090e6c
fix lint.
Rachelint 90cb038
print more information in error report.
Rachelint c2dcb60
fix clippy.
Rachelint d90b92b
improve comment of `SessionContextGenerator`.
Rachelint 58c0777
just use fixed `data_gen_rounds` and `ctx_gen_rounds` currently, beca…
Rachelint d5ff6ec
improve comments for rounds constants.
Rachelint 4b18d53
small improvements.
Rachelint fbf3a6e
select sql from some candidates ranther than fixed one.
Rachelint 79b0734
make `data_gen_rounds` able to set again, and add more tests.
Rachelint ca36a88
add no group cases.
Rachelint ea5e80b
add fuzz test for basic string aggr.
Rachelint 7f08f2b
make `data_gen_rounds` smaller.
Rachelint 9b0005b
add comments.
Rachelint 8040dc3
fix typo.
Rachelint 5c90a6b
fix comment.
Rachelint File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it would be easier to see what was happening if we made a few district explicity tests (rather than a single one that is mulit-threaded), though I see you are just following the existing pattern
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I am not so clear about
district explicity tests
, is it possible for some examples? I am please to try to make it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant like
Rather than a single test that was multi-threaded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. For me I found the error messages are messy in current pattern.
🤔 But
dataset
s andsession context
s in cases are randomly generated, seems hard to split cases?We can indeed consider more about how to make seeing things in the tests easier.