Refactor DependencyMap and Dependencies into structs
#12761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/stack_overflow
branch
from
225571e to
f61b74a
Compare
alamb
changed the title
DependencyMap and Dependencies into structs
alamb
force-pushed
the
alamb/stack_overflow
branch
from
f61b74a to
f24f9b9
Compare
…t + fix stack overflow
alamb
force-pushed
the
alamb/stack_overflow
branch
from
af65935 to
aae82c1
Compare
berkaysynnada
approved these changes
Oct 8, 2024
Co-authored-by: Berkay Şahin <124376117+berkaysynnada@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #12700
Rationale for this change
As part of debugging #12700 I wanted a way to print out the dependency maps in a human readable way, as well as better understand what was going on with dependencies in general
What changes are included in this PR?
DependencyMapandDependenciesfrom typedefs intostructs with methods and documentationDisplaywith a human readable descriptionAre these changes tested?
Covered by the existing tets
Are there any user-facing changes?