-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve AggregationFuzzer error reporting #12832
Conversation
@@ -237,45 +252,53 @@ struct AggregationFuzzTestTask { | |||
} | |||
|
|||
impl AggregationFuzzTestTask { | |||
async fn run(&self) { | |||
async fn run(&self) -> Result<()> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the key change is to return an actual DataFusionError
here and then print it when looking at the task output
### Sql:\n{}\n\ | ||
### Schema:\n{}\n\ | ||
### Session context params:\n{:?}\n\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we will also care about some information about reproducing like session context params
, sql
, when we encounter inconsistent results?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that information is already included when inconsistent results are detected (in check_result
) but perhaps I don't understand what you are proposing here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, it is my mistake, I see it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
THanks @Rachelint -- I am now just waiting for another committer to approve this PR so I can merge it |
Thank you @jonahgao |
Which issue does this PR close?
Part of #12114
Rationale for this change
@Rachelint added an amazing fuzzer framework in #12667 that actually found bugs already ❤️
However, the messages when it fails are hard to interpret
What changes are included in this PR?
DataFusionError
s and printing them rather thanunwrap
ing in a taskAre these changes tested?
I tested manually
Error before this PR:
Error after this PR:
Are there any user-facing changes?