Fix 2 bugs related to push down partition filters #12902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
This patch fixes 2 bugs. Errors in partition filters are ignored and that we allow partitions filters be push down for unpartition tables but we never evaluate such filters. The first bug is fixed by reporting errors for partition filters and only evaluating the filters we allowed as partition filters in `supports_filters_pushdown`. The second bug is fixed by only allowing partition filters to be pushed down when we have partition columns.
eejbyfeldt
force-pushed
the
12901-report-failures-in-partition-filters
branch
from
2d14277 to
708ef2f
Compare
eejbyfeldt
changed the title
eejbyfeldt
commented
Oct 13, 2024
alamb
approved these changes
Oct 16, 2024
|
🚀 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12901.
Rationale for this change
This patch fixes 2 bugs. Errors in partition filters are ignored and
that we allow partition filters to be pushed down for unpartitioned tables,
but we never evaluate such filters. This leads to correctness issues
in both cases.
What changes are included in this PR?
The first bug is fixed by reporting errors for partition filters and only evaluating the filters we allowed as partition filters in
supports_filters_pushdown.The second bug is fixed by only allowing partition filters to be pushed down when we have partition columns. Because we currently just ignore the filters in that case.
Are these changes tested?
Yes, using new and existing tests.
Are there any user-facing changes?
No.