Migrate Array function Documentation to code #12948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
alamb
changed the title
alamb
changed the title
alamb
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Thank you so much @jonathanc-n -- this is epic
I went through this PR carefully and it all looks good to me
| #### Aliases | ||
|
|
||
| - generate_series | ||
|
|
||
| ## Struct Functions | ||
|
|
||
| - [unnest](#unnest-struct) |
There was a problem hiding this comment.
I think unnest is special and not a scalar function. Perhaps as a follow on PR we can make a new page called "Special Functions" and put it there.
There was a problem hiding this comment.
Yeah, I can create one for that
There was a problem hiding this comment.
The only other special function I know of is make_map. See
| } | ||
| static DOCUMENTATION: OnceLock<Documentation> = OnceLock::new(); | ||
|
|
||
| fn get_flatten_doc() -> &'static Documentation { |
There was a problem hiding this comment.
this is so nice to have this documentation as part of the function
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
|
I ran |
|
🚀 |
This was referenced Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12927 .
Rationale for this change
What changes are included in this PR?
Moved the static array docs to the new one.
Are these changes tested?
Are there any user-facing changes?