Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce informative error on physical schema mismatch #13434

Conversation

findepi
Copy link
Member

@findepi findepi commented Nov 15, 2024

Which issue does this PR close?

For #12733

Rationale for this change

Better error message to help downstream projects and make it easier to provide reproducers

Example error message

Datafusion error: Internal error: Physical input schema should be the same as the one converted from logical input schema. Differences:
	- field nullability at index 3 [return_rank]: (physical) false vs (logical) true
	- field nullability at index 4 [currency_rank]: (physical) false vs (logical) true.
This was likely caused by a bug in DataFusion's code and we would welcome that you file an bug report in our issue tracker

What changes are included in this PR?

Enhanced error message when physical schema and schema-from-logical (aka logical schema) do not match as expected

Are these changes tested?

No

Are there any user-facing changes?

Yes

@github-actions github-actions bot added the core Core DataFusion crate label Nov 15, 2024
@findepi findepi changed the title Findepi/produce informative error on physical schema mismatch 61ecb7 Produce informative error on physical schema mismatch Nov 15, 2024
Include details that can help understand the problem.
@findepi findepi force-pushed the findepi/produce-informative-error-on-physical-schema-mismatch-61ecb7 branch from 110c8dd to c72478c Compare November 15, 2024 11:46
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- tahnk you @findepi

Copy link
Contributor

@jayzhan211 jayzhan211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb alamb merged commit 97045ec into apache:main Nov 17, 2024
26 checks passed
@alamb
Copy link
Contributor

alamb commented Nov 17, 2024

🥇

@findepi findepi deleted the findepi/produce-informative-error-on-physical-schema-mismatch-61ecb7 branch November 17, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants