Add support for DISTINCT + ORDER BY in ARRAY_AGG #14413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
gabotechs
force-pushed
the
array-agg-distinct-order-by
branch
from
9400d72 to
8eaacd6
Compare
gabotechs
force-pushed
the
array-agg-distinct-order-by
branch
from
8eaacd6 to
f23681c
Compare
gabotechs
changed the title
gabotechs
commented
Feb 2, 2025
| @@ -193,3 +193,149 @@ pub fn merge_ordered_arrays( | |||
|
|
|||
| Ok((merged_values, merged_orderings)) | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
| mod tests { | |||
There was a problem hiding this comment.
I moved this tests from
to this file, as they are just testing themerge_ordered_arrays function present in this file, and nothing related to ARRAY_AGG.
As I added there some unit tests that do test ARRAY_AGG, I though that it might be a good idea to move these ones out to a more suitable place.
Comment on lines
-342
to
+374
| if values.len() != 1 { | ||
| return internal_err!("expects single batch"); | ||
| if values.is_empty() { | ||
| return Ok(()); |
There was a problem hiding this comment.
As now the distinct accumulator can accept more than 1 batch because of the ordering, removing this restriction was necessary.
|
Close/reopen to rerun CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12371.
Rationale for this change
Completing ARRAY_AGG functionality as a prerequisite for adding the full functionality of STRING_AGG in #14412
What changes are included in this PR?
Adds a Postgres-style support for DISTINCT + ORDER_BY functionality, allowing users to issue statements like:
Note that there's a limitation that prohibits ordering by an expression that is not the same as the ARRAY_AGG argument. For example, the following queries are invalid:
This is the same limitation that exists on Postgres, example in Postgres fiddle
Are these changes tested?
yes, both in unit tests and sqllogictests
Are there any user-facing changes?
Users will now be able to issue ARRAY_AGG calls mixing DISTINCT and ORDER_BY clauses