Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept any uncorrelated plan when checking subquery correlation #14463

Closed
wants to merge 1 commit into from
Closed

Accept any uncorrelated plan when checking subquery correlation #14463

wants to merge 1 commit into from
+24 −21

Conversation

findepi
Copy link
Member

@findepi findepi commented Feb 3, 2025 •
edited by alamb
Loading

For the purpose of decorrelation, an uncorrelated plan is a unit. No verification needs to be performed on it.

This follows #13523 / #13498
it is believed to be a more correct solution to that issue, until we support real unnest decorrelation.

@github-actions github-actions bot added the logical-expr Logical plan and expressions label Feb 3, 2025
@findepi
Accept any uncorrelated plan when checking subquery correlation
d670b56 
For the purpose of decorrelation, an uncorrelated plan is a unit. No
verification needs to be performed on it.
@findepi findepi force-pushed the findepi/accept-any-uncorrelated-plan-when-checking-subquery-correlation-be1802 branch from fd7d6f0 to d670b56 Compare February 3, 2025 21:46
@findepi findepi requested a review from alamb February 4, 2025 06:34
@findepi findepi mentioned this pull request Feb 4, 2025
Open
alamb
alamb approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @findepi

This looks quite similar to #14474

Again, it would be great to add some test coverage to this code as well but since it has no tests now I don't think that is required for merge

@findepi
Copy link
Member Author

findepi commented Feb 5, 2025

This looks quite similar to #14474

Yes, that PR includes this as the first commit.

Will close in favor.

@findepi findepi closed this Feb 5, 2025
@findepi findepi deleted the findepi/accept-any-uncorrelated-plan-when-checking-subquery-correlation-be1802 branch February 5, 2025 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
logical-expr Logical plan and expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

check_correlations_in_subquery should not check uncorrelated plan nodes
2 participants
@findepi @alamb