Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize parquet_options in datafusion-proto #14465

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

blaginin
Copy link
Contributor

@blaginin blaginin commented Feb 3, 2025

Which issue does this PR close?

Rationale for this change

We don't currently serialize parquet_options in ParquetExec

What changes are included in this PR?

Write and optionally parse the value in protobuf

Are these changes tested?

Yes, extended a round trip test

Are there any user-facing changes?

No

@github-actions github-actions bot added the proto Related to proto crate label Feb 3, 2025
@blaginin blaginin marked this pull request as ready for review February 4, 2025 17:59
@alamb alamb changed the title Serialize parquet_options Serialize parquet_options in datafusion-proto Feb 4, 2025
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @blaginin -- very nice Detective work 🕵️

FYI @robtandy

@robtandy
Copy link
Contributor

robtandy commented Feb 4, 2025

Amazing! Thank you so much @blaginin !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proto Related to proto crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query produces different results after physical plan round trip to bytes
3 participants