Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): build error with wasm #14494

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

Lordworms
Copy link
Contributor

Which issue does this PR close?

like this https://github.com/apache/datafusion/actions/runs/13151403418/job/36699387339?pr=14493

Closes #.

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions github-actions bot added core Core DataFusion crate functions labels Feb 5, 2025
@Lordworms Lordworms force-pushed the fix_for_build_wasm branch 3 times, most recently from 024a4dc to 9dd5e89 Compare February 5, 2025 06:52
@Lordworms
Copy link
Contributor Author

cc @alamb

Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@xudong963 xudong963 merged commit fbd83de into apache:main Feb 5, 2025
27 checks passed
@alamb
Copy link
Contributor

alamb commented Feb 5, 2025

Thank you @Lordworms and @xudong963 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants