Fix JIT configs for aarch64 #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @yjshen |
|
I noticed this locally as well. Thx for fixing. |
houqp
reviewed
Mar 5, 2022
| // which might not reach all definitions; we can't handle that here, so | ||
| // we require long-range relocation types. | ||
| flag_builder.set("use_colocated_libcalls", "false").unwrap(); | ||
| flag_builder.set("is_pic", "false").unwrap(); |
There was a problem hiding this comment.
perhaps worth linking to bytecodealliance/wasmtime#2907 in the comment so we know to reenable pic when it's supported upstream.
|
Thanks again for fixing this. ❤️ |
jimexist
approved these changes
Mar 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Currently tests do not pass on Apple Silicone (or any non x86_64) platform. This PR adjusts JIT configs based on platform.
Should no longer be needed once bytecodealliance/wasmtime#2907 is closed.
Disclaimer: I don't really know what I'm doing here and am mostly applying the workaround from bytecodealliance/wasmtime#2735.
What changes are included in this PR?
Set the
is_picflag tofalsewhen creatingJITsincePLTis not supported on non x86 platforms.Are there any user-facing changes?
As far as I can tell, no
No