Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Add comment on input_schema from AggregateExec #7727

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Minor: Add comment on input_schema from AggregateExec #7727

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5096883
Remove input_schema
viirya Oct 3, 2023
c06693b
Revert "Remove input_schema"
viirya Oct 4, 2023
070c5a2
Add comment
viirya Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion datafusion/physical-plan/src/aggregates/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,9 @@ pub struct AggregateExec {
schema: SchemaRef,
/// Input schema before any aggregation is applied. For partial aggregate this will be the
/// same as input.schema() but for the final aggregate it will be the same as the input
/// to the partial aggregate
/// to the partial aggregate, i.e., partial and final aggregates have same `input_schema`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 I went to double check this (being inspired by the thoroughness of your own reviews @viirya ) and I was able to remove the entire field: #7741

/// We need the input schema of partial aggregate to be able to deserialize aggregate
/// expressions from protobuf for final aggregate.
pub input_schema: SchemaRef,
/// The columns map used to normalize out expressions like Partitioning and PhysicalSortExpr
/// The key is the column from the input schema and the values are the columns from the output schema
Expand Down