Minor: Improve comments in EnforceDistribution tests #8474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Dec 8, 2023
| @@ -928,7 +928,7 @@ fn add_roundrobin_on_top( | |||
| // If any of the following conditions is true | |||
| // - Preserving ordering is not helpful in terms of satisfying ordering requirements | |||
| // - Usage of order preserving variants is not desirable | |||
| // (determined by flag `config.optimizer.bounded_order_preserving_variants`) | |||
| // (determined by flag `config.optimizer.prefer_existing_sort`) | |||
There was a problem hiding this comment.
this config option was renamed to prefer_existing_sort but some of the comments and variable names refer to the old name
| @@ -2056,23 +2056,33 @@ pub(crate) mod tests { | |||
| } | |||
|
|
|||
| /// Runs the repartition optimizer and asserts the plan against the expected | |||
| /// Arguments | |||
There was a problem hiding this comment.
I found it very hard to read some of the tests as a line like this
assert_optimized!(expected, physical_plan, false, true);
As I had to go back to the macro definitions several times to remember what the false and true parameters meant
mustafasrepo
approved these changes
Dec 11, 2023
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Dec 15, 2023
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Jan 3, 2024
appletreeisyellow
pushed a commit
to appletreeisyellow/datafusion
that referenced
this pull request
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
related to #8451
Rationale for this change
While working on a reproducer for #8451 I noticed several things that could be improved in the EnforceDistribution tests
What changes are included in this PR?
Are these changes tested?
Covered by existing tests
Are there any user-facing changes?
No. It is a code cleanup only