Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include planning time in datafusion-cli printing #860

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

Dandandan
Copy link
Contributor

@Dandandan Dandandan commented Aug 11, 2021

Which issue does this PR close?

Closes #859

Rationale for this change

Planning / retrieving statistics / etc can take a considerable time. This makes the cost more visible.

Before:

> CREATE EXTERNAL TABLE lineitem STORED AS PARQUET LOCATION './lineitem/';
0 rows in set. Query took 0.000 seconds.

After:

> CREATE EXTERNAL TABLE lineitem STORED AS PARQUET LOCATION './lineitem/';
0 rows in set. Query took 1.999 seconds.

What changes are included in this PR?

Just moving the retrieval of start time before the sql call.

Are there any user-facing changes?

@Dandandan Dandandan added the enhancement New feature or request label Aug 11, 2021
@github-actions github-actions bot added the datafusion Changes in the datafusion crate label Aug 11, 2021
@Dandandan Dandandan merged commit 5bd7147 into apache:master Aug 12, 2021
@alamb
Copy link
Contributor

alamb commented Aug 12, 2021

Ooof -- 2s to load stats. 👍 for making it more visible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include planning time in datafusion-cli printing
3 participants