Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][UI] Unified local parameters UI #11186

Closed
2 of 3 tasks
caishunfeng opened this issue Jul 28, 2022 · 4 comments · Fixed by #11190
Closed
2 of 3 tasks

[Improvement][UI] Unified local parameters UI #11186

caishunfeng opened this issue Jul 28, 2022 · 4 comments · Fixed by #11190
Assignees
@hezean
Labels
help wanted Extra attention is needed improvement make more easy to user or prompt friendly release cherry-pick Mark this issue/PR had cherry-pick for release version UI ui and front end related
Milestone
3.0.1

Comments

@caishunfeng
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

Now ds has defferent local params UI for defferent task type.
Such as shell、sql、procedure, the local params UI has direct and type, because they support params pass:
image

and some task like flink、k8s, just has key and value, but the hidden logic is direct IN and type VARCHAR:
image

So it is better to unify the local parameters in the UI, and the tasks that do not support the params pass keep the unselectable direct IN and type VARCHAR, so that users can understand that this is not a bug, but that they do not support direct output.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@caishunfeng caishunfeng added improvement make more easy to user or prompt friendly Waiting for reply Waiting for reply UI ui and front end related help wanted Extra attention is needed and removed Waiting for reply Waiting for reply labels Jul 28, 2022
@github-actions
Copy link

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

@hezean
Copy link
Contributor

hezean commented Jul 28, 2022

Hi, may I work on it?

@caishunfeng
Copy link
Contributor Author

Hi, may I work on it?

@hezean Of course. I assign to you.

@caishunfeng caishunfeng added this to the 3.0.1 milestone Jul 28, 2022
@caishunfeng
Copy link
Contributor Author

related issue: #11071

@hezean hezean mentioned this issue Jul 28, 2022
Merged
@zhuangchong zhuangchong added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hezean hezean

Labels
help wanted Extra attention is needed improvement make more easy to user or prompt friendly release cherry-pick Mark this issue/PR had cherry-pick for release version UI ui and front end related
Projects
None yet
Milestone
3.0.1
Development

Successfully merging a pull request may close this issue.

[Improvement][UI] Unified local parameters UI hezean/dolphinscheduler
3 participants
@caishunfeng @zhuangchong @hezean