Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][UI] Unified local parameters UI #11190

Merged
merged 1 commit into from
Jul 29, 2022
Merged

[Improvement][UI] Unified local parameters UI #11190

merged 1 commit into from
Jul 29, 2022

Conversation

hezean
Copy link
Contributor

@hezean hezean commented Jul 28, 2022

Purpose of the pull request

Fixes #11186

Screen Shot 2022-07-28 at 19 08 21

@hezean hezean marked this pull request as draft July 28, 2022 11:44
@github-actions github-actions bot added the UI ui and front end related label Jul 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022 •
edited
Loading

Codecov Report

Merging #11190 (731542d) into dev (818648d) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #11190      +/-   ##
============================================
- Coverage     40.27%   40.18%   -0.10%     
- Complexity     4931     4950      +19     
============================================
  Files           982      988       +6     
  Lines         37568    37690     +122     
  Branches       4127     4140      +13     
============================================
+ Hits          15130    15145      +15     
- Misses        20903    21006     +103     
- Partials       1535     1539       +4
Impacted Files Coverage Δ
...erver/master/processor/queue/TaskEventService.java 69.64% <0.00%> (-10.72%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 55.12% <0.00%> (-1.29%) ⬇️
...cheduler/plugin/task/chunjun/ChunJunConstants.java 0.00% <0.00%> (ø)
...eduler/plugin/task/chunjun/ChunJunTaskChannel.java 0.00% <0.00%> (ø)
...phinscheduler/plugin/task/chunjun/ChunJunTask.java 0.00% <0.00%> (ø)
...ugin/task/chunjun/ChunJunTaskExecutionContext.java 0.00% <0.00%> (ø)
...plugin/task/chunjun/ChunJunTaskChannelFactory.java 0.00% <0.00%> (ø)
...heduler/plugin/task/chunjun/ChunJunParameters.java 75.86% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@hezean hezean marked this pull request as ready for review July 28, 2022 14:36
@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Amy0104
Amy0104 approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amy0104 Amy0104 added this to the 3.0.1 milestone Jul 29, 2022
@Amy0104 Amy0104 merged commit d85ea8f into apache:dev Jul 29, 2022
zhuangchong pushed a commit to zhuangchong/incubator-dolphinscheduler that referenced this pull request Sep 19, 2022
@hezean @zhuangchong
[Improvement][UI] Unified local parameters UI (apache#11190)
13d6d0f
@zhuangchong zhuangchong added the release cherry-pick Mark this issue/PR had cherry-pick for release version label Sep 19, 2022
@zhuangchong zhuangchong mentioned this pull request Sep 19, 2022
Merged
zhuangchong added a commit that referenced this pull request Sep 19, 2022
@zhuangchong @hezean
@devosend @sketchmind @Amy0104
[3.0.1-prepare][cherry-pick]3.0.1 UI 1 (#12033)
ffb58c1 
* [Improvement][UI] Unified local parameters UI (#11190)

* [Fix][UI] fix bug where icons are displayed in one line. (#11320)

* cherry pick [Improvement-11386][UI] Concise the logic available for task action buttons

* [Fix][UI] Fix the preTask options are unavailable when creating a tas...

* fix build

Co-authored-by: Chris Ho <realhezean@gmail.com>
Co-authored-by: Devosend <devosend@gmail.com>
Co-authored-by: Sheldon <39169452+sketchmind@users.noreply.github.com>
Co-authored-by: Amy0104 <amywang0104@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amy0104 Amy0104 Amy0104 approved these changes

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

Assignees

@hezean hezean

Labels
release cherry-pick Mark this issue/PR had cherry-pick for release version UI ui and front end related
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

[Improvement][UI] Unified local parameters UI
4 participants
@hezean @codecov-commenter @Amy0104 @zhuangchong