Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [dolphinscheduler-api] create presto datasource failed with extra "jdbc connect parameters" #11726

Closed
3 tasks done
izualzhy opened this issue Sep 1, 2022 · 3 comments · Fixed by #15093
Closed
3 tasks done
Assignees
Labels
backend bug Something isn't working

Comments

@izualzhy
Copy link
Contributor

izualzhy commented Sep 1, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

When try to create PRESTO datasource type, if jdbc connect parameters assigned.
TestConnect will be failed with tips "JDBC connect failed".

For example, use {"SSL":"true"} as connect params:
image

the logs will shows:

[ERROR] 2022-09-01 11:38:21.728 +0800 com.zaxxer.hikari.pool.HikariPool:[594] - HikariPool-2 - Exception during pool initialization.
java.sql.SQLException: Connection property 'SSL' is both in the URL and an argument

What you expected to happen

Because "SSL" is a valid property when connect presto, so the test connect should be success.

How to reproduce

As above.
Two points mentioned:

  1. plz just use jdbc connet params at first to avoid the dataSourceClientCache, bcz cache key does not contain params.
  2. IMO, when connect presto, we can set params either in jdbc-url or properties, However, the same parameter may not be specified using both methods, ref to JDBC driver
    I'm pleasure to fix this, and what is next?

Anything else

Every time happens.

Version

3.0.0

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@izualzhy izualzhy added bug Something isn't working Waiting for reply Waiting for reply labels Sep 1, 2022
@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

@SbloodyS SbloodyS added backend and removed Waiting for reply Waiting for reply labels Sep 1, 2022
@github-actions
Copy link

github-actions bot commented Oct 2, 2022

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Oct 2, 2022
@github-actions
Copy link

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.

@SbloodyS SbloodyS reopened this Oct 30, 2023
@SbloodyS SbloodyS removed the Stale label Nov 3, 2023
SbloodyS added a commit that referenced this issue Nov 3, 2023
…d an argument (#15093)

Co-authored-by: zhangying14 <zhangying14@zuoyebang.com>
Co-authored-by: xiangzihao <460888207@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants