Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Style] Spotless sometimes fails to detect and block wildcard imports #12401

Closed
3 tasks done
EricGao888 opened this issue Oct 17, 2022 · 3 comments · Fixed by #12412
Closed
3 tasks done

[Bug][Style] Spotless sometimes fails to detect and block wildcard imports #12401

EricGao888 opened this issue Oct 17, 2022 · 3 comments · Fixed by #12412
Assignees
Labels
bug Something isn't working CI&CD priority:high
Milestone

Comments

@EricGao888
Copy link
Member

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

What you expected to happen

  • Spotless should be able to detect and block wildcard imports in code.

How to reproduce

  • WIP, will update this section later.

Anything else

No response

Version

dev

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@github-actions
Copy link

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

@EricGao888
Copy link
Member Author

When #11412 is done, this issue will get fixed.

@EricGao888
Copy link
Member Author

When #11412 is done, this issue will get fixed.

After reconsideration, instead of tangling with ratchetFrom, I believe a better way is to fix all the legacy style errors once for all. We have been using Spotless for several months and most style errors have been fixed. Now it's a good time to fix the rest and it will also help maintainer review PR more easily without bothered by those style fix. I will submit a PR later this week to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI&CD priority:high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant