Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement][Style] Fix remaining style errors and wildcard imports #12412

Merged
merged 6 commits into from
Oct 19, 2022
Merged

[Improvement][Style] Fix remaining style errors and wildcard imports #12412

merged 6 commits into from
Oct 19, 2022

Conversation

EricGao888
Copy link
Member

@EricGao888 EricGao888 commented Oct 18, 2022 •
edited
Loading

Purpose of the pull request

Brief change log

  • Already described above.

Verify this pull request

  • Only code style fix.

@EricGao888 EricGao888 self-assigned this Oct 18, 2022
@EricGao888 EricGao888 added improvement make more easy to user or prompt friendly backend CI&CD labels Oct 18, 2022
@EricGao888 EricGao888 added this to the 3.2.0 milestone Oct 18, 2022
@EricGao888 EricGao888 marked this pull request as ready for review October 18, 2022 04:25
@github-actions github-actions bot added document Python UI ui and front end related and removed CI&CD labels Oct 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022 •
edited
Loading

Codecov Report

Merging #12412 (74810b5) into dev (ba53806) will increase coverage by 0.15%.
The diff coverage is 65.86%.

❗ Current head 74810b5 differs from pull request most recent head 6177ae8. Consider uploading reports for the commit 6177ae8 to get more accurate results

@@             Coverage Diff              @@
##                dev   #12412      +/-   ##
============================================
+ Coverage     39.22%   39.38%   +0.15%     
- Complexity     4212     4213       +1     
============================================
  Files          1040     1040              
  Lines         38795    39153     +358     
  Branches       4460     4480      +20     
============================================
+ Hits          15218    15421     +203     
- Misses        21802    21954     +152     
- Partials       1775     1778       +3
Impacted Files Coverage Δ
...plugin/alert/dingtalk/DingTalkParamsConstants.java 0.00% <ø> (ø)
...cheduler/plugin/alert/email/EmailAlertChannel.java 47.61% <ø> (ø)
...inscheduler/plugin/alert/email/EmailConstants.java 0.00% <ø> (ø)
...eduler/plugin/alert/email/MailParamsConstants.java 0.00% <ø> (ø)
...olphinscheduler/plugin/alert/email/MailSender.java 50.68% <0.00%> (-0.35%) ⬇️
...gin/alert/email/exception/AlertEmailException.java 50.00% <ø> (ø)
...ugin/alert/email/template/DefaultHTMLTemplate.java 79.24% <0.00%> (-1.53%) ⬇️
...eduler/plugin/alert/feishu/FeiShuAlertChannel.java 16.66% <ø> (ø)
...ler/plugin/alert/feishu/FeiShuParamsConstants.java 0.00% <ø> (ø)
...hinscheduler/plugin/alert/feishu/FeiShuSender.java 46.55% <0.00%> (-1.24%) ⬇️
... and 501 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 18, 2022
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 35 Code Smells

49.0% 49.0% Coverage
0.8% 0.8% Duplication

@EricGao888
Copy link
Member Author

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

This PR is only style fix. Will fix those potential problems in another PRs.

@EricGao888
Copy link
Member Author

EricGao888 commented Oct 19, 2022 •
edited
Loading

image
The check result of dead link is false negative. This link works for me. https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/creating-a-personal-access-token

caishunfeng
caishunfeng approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @EricGao888

@EricGao888 EricGao888 merged commit d46e465 into apache:dev Oct 19, 2022
Chris-Arith pushed a commit to Chris-Arith/dolphinscheduler that referenced this pull request Oct 26, 2022
@EricGao888 @Chris-Arith
[Improvement][Style] Fix remaining style errors and wildcard imports (a…
f0ff451 
…pache#12412)

* Fix remaining style errors and wildcard imports

* Upgrade spotless to the latest stable version, exclude .github folder from spotless check and fix dead link

* Fix spotless matching scope of markdown files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

@caishunfeng caishunfeng caishunfeng approved these changes

@zhongjiajie zhongjiajie Awaiting requested review from zhongjiajie

@Tianqi-Dotes Tianqi-Dotes Awaiting requested review from Tianqi-Dotes

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun is a code owner

Assignees

@EricGao888 EricGao888

Labels
backend document improvement make more easy to user or prompt friendly Python UI ui and front end related
Projects
None yet
Milestone
3.2.0
4 participants
@EricGao888 @codecov-commenter @caishunfeng @kezhenxu94