Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][DataSource] delete the password and test again, it is successful without password #9428

Closed
3 tasks done
wqxs opened this issue Apr 11, 2022 · 4 comments · Fixed by #9531
Closed
3 tasks done

[Bug][DataSource] delete the password and test again, it is successful without password #9428

wqxs opened this issue Apr 11, 2022 · 4 comments · Fixed by #9531
Assignees
@wqxs
Labels
bug Something isn't working
Milestone
2.0.6

Comments

@wqxs
Copy link
Contributor

wqxs commented Apr 11, 2022

Search before asking

  • I had searched in the issues and found no similar issues.

What happened

In the data source function module, I select the postgresql type data source. After the test is successful, I delete the password for the test, or it is successful.

What you expected to happen

Uploading image.png…

How to reproduce

Fill in the correct data source connection information first, after the test is successful, delete the password, and then test

Anything else

The reason for the problem is because: the DataSourceClient created by dbType, user and jdbcUrl as the key when getting the DatasourceUniqueId in the 55th line of the DataSourceClientProvider, so the first DataSourceClient is found in the second test, So there will be cases where the test can be successful without a password

Version

2.0.5

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@wqxs wqxs added bug Something isn't working Waiting for reply Waiting for reply labels Apr 11, 2022
@github-actions
Copy link

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

@lenboo
Copy link
Contributor

lenboo commented Apr 11, 2022

The image upload failed, please try again.

@wqxs
Copy link
Contributor Author

wqxs commented Apr 11, 2022

image

@wqxs
Copy link
Contributor Author

wqxs commented Apr 11, 2022

The image upload failed, please try again.
162661663-cf221498-5ddb-42a5-9f01-13d85ce971de

@caishunfeng caishunfeng removed the Waiting for reply Waiting for reply label Apr 12, 2022
@caishunfeng caishunfeng added this to the 2.0.6-release milestone Apr 12, 2022
@caishunfeng caishunfeng changed the title datasource bug [Bug][DataSource] delete the password and test again, it is successful without password Apr 12, 2022
wqxs added a commit to wqxs/dolphinscheduler that referenced this issue Apr 16, 2022
@wqxs
[fix-9428] [DataSource] delete the password and test again, it is suc…
aa7d709 
…cessful without password bug (apache#9428)

* fix bug: After the test data source is successful, delete the password, re-test, or success

* Modify the method of generating DatasourceUniqueId
@wqxs wqxs mentioned this issue Apr 16, 2022
Closed
wqxs added a commit to wqxs/dolphinscheduler that referenced this issue Apr 16, 2022
@wqxs
[fix-9428] [DataSource] delete the password and test again, it is suc…
0cf2d8c 
…cessful without password bug (apache#9428)

* fix bug: After the test data source is successful, delete the password, re-test, or success

* Modify the method of generating DatasourceUniqueId
@wqxs wqxs mentioned this issue Apr 16, 2022
Merged
caishunfeng pushed a commit that referenced this issue Apr 18, 2022
@wqxs
[fix-9428] [DataSource] delete the password and test again, it is suc…
32f76e4 
…cessful without password bug (#9428) (#9531)

* fix bug: After the test data source is successful, delete the password, re-test, or success

* Modify the method of generating DatasourceUniqueId
Tianqi-Dotes pushed a commit to Tianqi-Dotes/dolphinscheduler that referenced this issue Jun 16, 2022
@wqxs @caishunfeng
[fix-9428] [DataSource] delete the password and test again, it is suc…
763e019 
…cessful without password bug (apache#9428) (apache#9531)

* fix bug: After the test data source is successful, delete the password, re-test, or success

* Modify the method of generating DatasourceUniqueId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wqxs wqxs

Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.6
3 participants
@caishunfeng @lenboo @wqxs