Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][python] sql type can not be specified #9665

Closed
3 tasks done
hiSandog opened this issue Apr 22, 2022 · 2 comments · Fixed by #9673
Closed
3 tasks done

[Improvement][python] sql type can not be specified #9665

hiSandog opened this issue Apr 22, 2022 · 2 comments · Fixed by #9673
Assignees
Labels
bug Something isn't working Python

Comments

@hiSandog
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

When I deploy sql task through python-gate.
Sql type will be identified by the regex.
I think it should be specified by a parameter.

当我通过python gate 上传一个 sql 类型的任务时
sql 的类型(SELECT / NOT_SELECT) 只能通过正则确定
应该通过一个参数指定更加直观一点

Use case

I can't create table task through python-gate.
Because the "create table xxx" sql will be identified as "SELECT" type.

当我想弄一个 创建表 的sql任务,它会被认定为 "SELECT" 类型,会导致任务失败,因为 正则表达式 是
"^(?!(.* |)insert |(.* |)delete |(.* |)drop |(.* |)update |(.* |)alter ).*"

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@hiSandog hiSandog added feature new feature Waiting for reply Waiting for reply labels Apr 22, 2022
@github-actions
Copy link

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

When I deploy sql task through python-gate.
Sql type will be identified by the regex.
I think it should be specified by a parameter.

When I upload a sql type task through python gate
The type of sql (SELECT / NOT_SELECT) can only be determined by regular
It should be more intuitive to specify through a parameter

Use case

I can't create table task through python-gate.
Because the "create table xxx" sql will be identified as "SELECT" type.

When I try to make a sql task that creates a table, it will be recognized as "SELECT" type, which will cause the task to fail because the regular expression is
"^(?!(.* |)insert |(.* |)delete |(.* |)drop |(.* |)update |(.* |)alter ).*"

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@github-actions
Copy link

Thank you for your feedback, we have received your issue, Please wait patiently for a reply.

  • In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
  • If you haven't received a reply for a long time, you can join our slack and send your question to channel #troubleshooting

@SbloodyS SbloodyS removed the Waiting for reply Waiting for reply label Apr 22, 2022
@zhongjiajie zhongjiajie added bug Something isn't working Python and removed feature new feature labels Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Python
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants