-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement-9665][python] add create table regex #9673
Conversation
I will take a look tomorrow |
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/tasks/sql.py
Outdated
Show resolved
Hide resolved
BTW, i think your point on issues is great
We need to implement the override of user-specified dolphinscheduler/dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/tasks/sql.py Line 63 in 0c7aa4e
self.sql_type: Optional[str] = "select", and add the overwrite logic in function if self.sql_type is sprcific dolphinscheduler/dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/tasks/sql.py Lines 77 to 87 in 0c7aa4e
|
Codecov Report
@@ Coverage Diff @@
## dev #9673 +/- ##
============================================
- Coverage 40.00% 40.00% -0.01%
+ Complexity 4473 4472 -1
============================================
Files 835 835
Lines 33549 33550 +1
Branches 3709 3710 +1
============================================
Hits 13421 13421
+ Misses 18882 18880 -2
- Partials 1246 1249 +3
Continue to review full report at Codecov.
|
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/tasks/sql.py
Outdated
Show resolved
Hide resolved
dolphinscheduler-python/pydolphinscheduler/src/pydolphinscheduler/tasks/sql.py
Show resolved
Hide resolved
BTW, ci failed with python lint error
TL;TR and we have the way about run your code locally which you could see in https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-python/pydolphinscheduler/DEVELOP.md#test-your-code |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks and good catch
Thanks @hiSandog for the contribution |
At this stage, creating a table cannot use SQL Task through python-gate.It will be recognized as "SELECT" type, which will cause the task to fail.
So, add create table regex.
This pr will close #9665