Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix-10083][Doc]Change Docker cmd && Change WebexTeams Chinese Translation #10084

Merged
merged 2 commits into from
May 18, 2022
Merged

[Fix-10083][Doc]Change Docker cmd && Change WebexTeams Chinese Translation #10084

merged 2 commits into from
May 18, 2022

Conversation

qingwli
Copy link
Member

@qingwli qingwli commented May 18, 2022

close #10083

@qingwli
Copy link
Member Author

qingwli commented May 18, 2022

PTAL @caishunfeng @zhongjiajie

@qingwli qingwli changed the title [Fix-10083][Docker]Change Docker cmd && Change WebexTeams Chinese Translation [Fix-10083][Doc]Change Docker cmd && Change WebexTeams Chinese Translation May 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2022 •
edited
Loading

Codecov Report

Merging #10084 (ccdd54d) into dev (cd70ad5) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #10084      +/-   ##
============================================
- Coverage     40.89%   40.85%   -0.04%     
+ Complexity     4637     4633       -4     
============================================
  Files           839      839              
  Lines         34015    34015              
  Branches       3772     3772              
============================================
- Hits          13910    13897      -13     
- Misses        18773    18785      +12     
- Partials       1332     1333       +1
Impacted Files Coverage Δ
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 48.21% <0.00%> (-7.15%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.70% <0.00%> (-2.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd70ad5...ccdd54d. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented May 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

SbloodyS
SbloodyS approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

caishunfeng
caishunfeng approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit cab46e6 into apache:dev May 18, 2022
rockfang pushed a commit to rockfang/dolphinscheduler that referenced this pull request May 18, 2022
@qingwli @rockfang
[Fix-10083][Doc]Change Docker cmd && Change WebexTeams Chinese Transl…
32fb3cd 
…ation (apache#10084)

* Change Docker cmd && Change WebexTeams Chinese Translation

* run ci

Co-authored-by: qingwli <qingwli@cisco.com>
@zhongjiajie zhongjiajie added this to the 3.0.0-beta-1 milestone May 25, 2022
zhongjiajie pushed a commit that referenced this pull request May 25, 2022
@qingwli @zhongjiajie
[Fix-10083][Doc]Change Docker cmd && Change WebexTeams Chinese Transl…
1352d3d 
…ation (#10084)

* Change Docker cmd && Change WebexTeams Chinese Translation

* run ci

Co-authored-by: qingwli <qingwli@cisco.com>
(cherry picked from commit cab46e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SbloodyS SbloodyS SbloodyS approved these changes

@caishunfeng caishunfeng caishunfeng approved these changes

@zhongjiajie zhongjiajie Awaiting requested review from zhongjiajie

@Tianqi-Dotes Tianqi-Dotes Awaiting requested review from Tianqi-Dotes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-beta-1
Development

Successfully merging this pull request may close these issues.

[Bug] [Docker] Docker Doc Error && Alert Plugin WebexTeams Chinese Translation Error
5 participants
@qingwli @codecov-commenter @caishunfeng @SbloodyS @zhongjiajie