Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][UI] Fix the problem that the failure strategy field in the time management form is multilingual. #10169

Merged
merged 1 commit into from
May 20, 2022

Conversation

songjianet
Copy link
Member

@songjianet songjianet commented May 20, 2022

Purpose of the pull request

close #10140

image
image
image
image

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@songjianet songjianet added bug Something isn't working UI ui and front end related labels May 20, 2022
@songjianet songjianet added this to the 3.0.0-beta-1 milestone May 20, 2022
@songjianet songjianet self-assigned this May 20, 2022
Copy link
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #10169 (56c630e) into dev (c07339b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #10169      +/-   ##
============================================
- Coverage     40.84%   40.84%   -0.01%     
+ Complexity     4716     4715       -1     
============================================
  Files           854      854              
  Lines         34503    34503              
  Branches       3814     3814              
============================================
- Hits          14093    14092       -1     
  Misses        19056    19056              
- Partials       1354     1355       +1     
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c07339b...56c630e. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@songjianet songjianet merged commit dc61370 into apache:dev May 20, 2022
@songjianet songjianet deleted the fix-timming branch May 23, 2022 03:52
zhongjiajie pushed a commit that referenced this pull request May 23, 2022
… management form is multilingual. (#10169)

(cherry picked from commit dc61370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI ui and front end related
Projects
None yet
3 participants