Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix][UI] Fix specific week init bug for timing #10183

Merged
merged 1 commit into from
May 22, 2022
Merged

[Fix][UI] Fix specific week init bug for timing #10183

merged 1 commit into from
May 22, 2022

Conversation

devosend
Copy link
Contributor

close #10139

@devosend devosend added bug Something isn't working UI ui and front end related labels May 22, 2022
@devosend devosend added this to the 3.0.0-beta-1 milestone May 22, 2022
@devosend devosend self-assigned this May 22, 2022
labbomb
labbomb approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #10183 (818cfa0) into dev (0ef02e8) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #10183      +/-   ##
============================================
- Coverage     40.94%   40.93%   -0.02%     
+ Complexity     4732     4729       -3     
============================================
  Files           854      854              
  Lines         34553    34553              
  Branches       3818     3818              
============================================
- Hits          14149    14144       -5     
- Misses        19050    19056       +6     
+ Partials       1354     1353       -1
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (-1.41%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 53.33% <0.00%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ef02e8...818cfa0. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented May 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Amy0104
Amy0104 approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Amy0104 Amy0104 merged commit d7d6699 into apache:dev May 22, 2022
@Amy0104 Amy0104 changed the title [Fix][UI] Fix spcial week init bug for timing [Fix][UI] Fix special week init bug for timing May 22, 2022
@devosend devosend changed the title [Fix][UI] Fix special week init bug for timing [Fix][UI] Fix specific week init bug for timing May 22, 2022
zhongjiajie pushed a commit that referenced this pull request May 23, 2022
@devosend @zhongjiajie
fix spcial week init bug (#10183)
8a52958 
(cherry picked from commit d7d6699)
ITBOX-ITBOY pushed a commit to ITBOX-ITBOY/dolphinscheduler that referenced this pull request Jul 8, 2022
@devosend
fix spcial week init bug (apache#10183)
6f596b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amy0104 Amy0104 Amy0104 approved these changes

@labbomb labbomb labbomb approved these changes

Assignees

@devosend devosend

Labels
bug Something isn't working UI ui and front end related
Projects
None yet
Milestone
3.0.0-beta-1
4 participants
@devosend @codecov-commenter @labbomb @Amy0104