[Fix][UI] Fix data-quality component multi-language support. #10202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amy0104
reviewed
May 23, 2022
| const items = JSON.parse(result).map((item: IResponseJsonItem) => { | ||
| item.props.placeholder = t('project.node.' + item.props.placeholder.split(' ').join('_').split(',').join('').toLowerCase()) | ||
| return formatResponseJson(item) | ||
| }) |
There was a problem hiding this comment.
It's better to handle the placeholder format in the formatResponseJson function as well.
Codecov Report
@@ Coverage Diff @@
## dev #10202 +/- ##
============================================
- Coverage 40.94% 40.92% -0.02%
+ Complexity 4732 4728 -4
============================================
Files 854 854
Lines 34553 34553
Branches 3818 3818
============================================
- Hits 14148 14142 -6
- Misses 19051 19053 +2
- Partials 1354 1358 +4
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
zhongjiajie
pushed a commit
that referenced
this pull request
May 24, 2022
* [Fix][UI] Fix data-quality component multi-language support. * [Fix][UI] Fix data-quality component multi-language support. (cherry picked from commit c8a4c69)
ITBOX-ITBOY
pushed a commit
to ITBOX-ITBOY/dolphinscheduler
that referenced
this pull request
Jul 8, 2022
…10202) * [Fix][UI] Fix data-quality component multi-language support. * [Fix][UI] Fix data-quality component multi-language support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
close #10138
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: