Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][UI] Fix status statistics card height is inconsistent. #10268

Merged
merged 1 commit into from
May 27, 2022

Conversation

songjianet
Copy link
Member

Purpose of the pull request

close #10266
image

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@songjianet songjianet added bug Something isn't working UI ui and front end related labels May 27, 2022
@songjianet songjianet added this to the 3.0.0-beta-2 milestone May 27, 2022
@songjianet songjianet self-assigned this May 27, 2022
Copy link
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

Codecov Report

Merging #10268 (799775f) into dev (4c1ef0a) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #10268      +/-   ##
============================================
- Coverage     41.25%   41.24%   -0.01%     
+ Complexity     4760     4759       -1     
============================================
  Files           854      854              
  Lines         34579    34579              
  Branches       3821     3821              
============================================
- Hits          14265    14263       -2     
- Misses        18944    18945       +1     
- Partials       1370     1371       +1     
Impacted Files Coverage Δ
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 53.33% <0.00%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c1ef0a...799775f. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented May 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@songjianet songjianet merged commit 1ac534b into apache:dev May 27, 2022
@songjianet songjianet deleted the fix-home branch May 27, 2022 11:16
devosend pushed a commit that referenced this pull request Jun 17, 2022
ITBOX-ITBOY pushed a commit to ITBOX-ITBOY/dolphinscheduler that referenced this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug-FE] [Home] Status statistics card height is inconsistent.
5 participants