Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][UI] Add mapping_columns filed for the data_quality ruleInputPar… #10286

Merged
merged 1 commit into from
May 30, 2022

Conversation

Amy0104
Copy link
Member

@Amy0104 Amy0104 commented May 30, 2022

…amter.

Purpose of the pull request

This pull request adds mapping_columns filed for the data_quality ruleInputParmter.

Brief change log

image

Related Issue

close #9988

@Amy0104 Amy0104 added bug Something isn't working UI ui and front end related labels May 30, 2022
@Amy0104 Amy0104 added this to the 3.0.0-beta-2 milestone May 30, 2022
@Amy0104 Amy0104 self-assigned this May 30, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #10286 (979cdd3) into dev (13af2ad) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #10286      +/-   ##
============================================
- Coverage     41.17%   41.14%   -0.03%     
+ Complexity     4760     4758       -2     
============================================
  Files           855      855              
  Lines         34621    34621              
  Branches       3826     3826              
============================================
- Hits          14254    14244      -10     
- Misses        18991    19001      +10     
  Partials       1376     1376              
Impacted Files Coverage Δ
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 48.21% <0.00%> (-8.04%) ⬇️
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13af2ad...979cdd3. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@labbomb labbomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet merged commit e7fbfa3 into apache:dev May 30, 2022
devosend pushed a commit that referenced this pull request Jun 17, 2022
@Amy0104 Amy0104 deleted the fix/9988 branch June 27, 2022 06:10
ITBOX-ITBOY pushed a commit to ITBOX-ITBOY/dolphinscheduler that referenced this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment