Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-10318][ui] Fix EMR Task UI custom parameters Is not correct #10334

Merged
merged 1 commit into from
Jun 2, 2022

Conversation

guodongym
Copy link
Contributor

@guodongym guodongym commented Jun 1, 2022

Purpose of the pull request

Fix EMR Task UI custom parameters Is not correct close #10318

Brief change log

Modify useCustomParams isSimple: true

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@SbloodyS
Copy link
Member

SbloodyS commented Jun 2, 2022

Please associate the corresponding issue to this PR. @guodongym

@SbloodyS SbloodyS requested a review from Amy0104 June 2, 2022 01:29
@SbloodyS SbloodyS added the UI ui and front end related label Jun 2, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #10334 (7faa465) into dev (e8ad62b) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #10334      +/-   ##
============================================
- Coverage     40.43%   40.42%   -0.02%     
+ Complexity     4781     4779       -2     
============================================
  Files           868      868              
  Lines         35374    35374              
  Branches       3945     3945              
============================================
- Hits          14304    14300       -4     
- Misses        19633    19639       +6     
+ Partials       1437     1435       -2     
Impacted Files Coverage Δ
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (-1.41%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 53.33% <0.00%> (-1.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8ad62b...7faa465. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@guodongym
Copy link
Contributor Author

Please associate the corresponding issue to this PR. @guodongym

Has been associated

Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Amy0104 Amy0104 merged commit 96496f7 into apache:dev Jun 2, 2022
@devosend devosend modified the milestone: 3.0.0-beta-2 Jun 17, 2022
devosend pushed a commit that referenced this pull request Jun 17, 2022
)

* Modify useCustomParams isSimple: true

(cherry picked from commit 96496f7)
ITBOX-ITBOY pushed a commit to ITBOX-ITBOY/dolphinscheduler that referenced this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [UI] EMR Task UI custom parameters Is not correct
5 participants