-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade log4j #10359
upgrade log4j #10359
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #10359 +/- ##
============================================
- Coverage 40.18% 40.18% -0.01%
+ Complexity 4727 4726 -1
============================================
Files 871 871
Lines 35375 35375
Branches 3943 3943
============================================
- Hits 14215 14214 -1
Misses 19731 19731
- Partials 1429 1430 +1
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed! |
Any update @pjfanning |
@kezhenxu94 the change in this PR is the only place where dolphinscheduler explicitly uses an old version of log4j. There are quite a few old dependencies of dolphinscheduler that are bringing in old log4j dependencies though.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is just an E2E dependency and they won't be included in distribution package though
(cherry picked from commit f90f0f8)
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: